test: Fix the docker-clone make target to exit failure. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/busted-clone
branch
from
2516035 to
b43e0c2
Compare
smoser
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 13.01% 13.01%
=======================================
Files 40 40
Lines 6003 6003
=======================================
Hits 781 781
Misses 5094 5094
Partials 128 128 ☔ View full report in Codecov by Sentry. |
My expectation was that when make invoked the shell (sh) for
a line in a rule was that it did so with '-e'. That was an
incorrect assumption.
The make docker-clone target was basically doing:
for i in url1 url2 url3; do
something $i; done
The failure of the *last* item in the list should cause the
command to exit failure, but failure of an earlier command would not.
The change here is just to move that shell code into a script in
tools/oci-copy and call it from there.
Signed-off-by: Scott Moser <[email protected]>
smoser
force-pushed
the
fix/busted-clone
branch
from
b43e0c2 to
b0bedb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: Fix the docker-clone make target to exit failure.
My expectation was that when make invoked the shell (sh) for
a line in a rule was that it did so with '-e'. That was an
incorrect assumption.
The make docker-clone target was basically doing:
The failure of the last item in the list should cause the
command to exit failure, but failure of an earlier command would not.
The change here is just to move that shell code into a script in
tools/oci-copy and call it from there.