Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update go.mod to keep deps stable for compression behaviors #555

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha force-pushed the upstream-rel-0.40.x branch 2 times, most recently from 2fb1b55 to 3ac6ae6 Compare November 20, 2023 19:11
Copy link
Contributor

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: update go.mod to keep deps stable for compression behaviors

Can you explain in your commit message more of what you're doing?

That is probably obvious to you right now, but its not obvious to me and I suspect it won't be obvious to a future-you either.

@rchincha
Copy link
Contributor Author

fix: update go.mod to keep deps stable for compression behaviors

Can you explain in your commit message more of what you're doing?

That is probably obvious to you right now, but its not obvious to me and I suspect it won't be obvious to a future-you either.

Will update.
We are using stacker, docker and skopeo together. And we want to pin some versions and keep the deps identical. This is not ideal until compression gets properly addressed upstream.

This go.mod has been updated to:
github.com/containers/image/v5 v5.24.2
github.com/klauspost/pgzip v1.2.6

to be in sync with skopeo v1.13.3

Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha rchincha force-pushed the upstream-rel-0.40.x branch from 3ac6ae6 to e483a9d Compare November 21, 2023 22:00
Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha rchincha merged commit b01573b into project-stacker:rel-0.40.x Nov 22, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants