ci: Only upload coverage when running coverage workflow, not build. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a pull request (project-stacker#557) that changed a single line in a single integration test. c-i reported that coverage changed: 5.72% (-48.53%) compared to a34ebfa Where a34ebfa was the previous commit. That doesn't sound right. I think what is happening is that we have multiple uploads of the coverage workflow and they're fighting. There isn't any reason to upload both anyway. Signed-off-by: Scott Moser <[email protected]>
|
the code coverage run showing the big change is https://app.codecov.io/gh/project-stacker/stacker/pull/557 . |
|
Close this because #559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a pull request (#557) that changed a single line in a single integration test. c-i reported that coverage changed:
5.72% (-48.53%) compared to a34ebfa
Where a34ebfa was the previous commit.
That doesn't sound right. I think what is happening is that we have multiple uploads of the coverage workflow and they're fighting.
There isn't any reason to upload both anyway.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.