Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch idmap from lxd to incus #578

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

hallyn
Copy link
Contributor

@hallyn hallyn commented Dec 14, 2023

Incus had moved idmap from shared/ to internal/.

This is a draft pr to test with my custom incus which moves it back.

@hallyn hallyn marked this pull request as ready for review December 15, 2023 20:32
@hallyn hallyn force-pushed the 2023-12-14/incus branch 3 times, most recently from 6d17069 to 00e6ced Compare December 15, 2023 21:45
To avoid license oddnesses.

Signed-off-by: Serge Hallyn <[email protected]>
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec24577) 57.14% compared to head (833f01a) 57.10%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   57.14%   57.10%   -0.04%     
==========================================
  Files          64       64              
  Lines        7516     7519       +3     
==========================================
- Hits         4295     4294       -1     
- Misses       2479     2483       +4     
  Partials      742      742              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit a396596 into project-stacker:main Dec 15, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants