Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update stacker-bom dep #590

Merged
merged 2 commits into from
Feb 8, 2024
Merged

chore: update stacker-bom dep #590

merged 2 commits into from
Feb 8, 2024

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Feb 5, 2024

project-stacker/stacker-bom#57

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hallyn
Copy link
Contributor

hallyn commented Feb 6, 2024

Hm, these ci failures sure do seem unrelated...

@hallyn
Copy link
Contributor

hallyn commented Feb 6, 2024

Oh, no, this is a stacker-bom failure I guess:

7965 2024-02-06T00:17:11.0606144Z # {"level":"info","file":"/file1","package":"pkg1","time":"2024-02-06T00:17:03Z","message":"adding file to package"}
7966 2024-02-06T00:17:11.0607977Z # time="2024-02-06T00:17:03Z" level=info msg="Package SPDXRef-Package-pkg1 has 2 relationships defined"
7967 2024-02-06T00:17:11.0611665Z # {"level":"error","error":"serializing document: pre-rendering the document: rendering pkg pkg1 :computing verification code: unable to render package, files were analyzed but      some do not have sha1 checksums","path":"/stacker/artifacts/doc-pkg1.spdx.json","time":"2024-02-06T00:17:03Z","message":"unable to write output"}
7968 2024-02-06T00:17:11.0615757Z # error: serializing document: pre-rendering the document: rendering pkg pkg1 :computing verification code: unable to render package, files were analyzed but some do not have sh     a1 checksums
7969 2024-02-06T00:17:11.0617278Z # failed to generate layer artifacts for bom-alpine - execute failed: exit status 1
7970 2024-02-06T00:17:11.0617883Z # error: exit status 1

Some sbom verification tools require that the sbom not have empty
packages (packages without files)

Signed-off-by: Ramkumar Chinchani <[email protected]>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3177e8d) 57.15% compared to head (3d1da55) 55.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   57.15%   55.77%   -1.39%     
==========================================
  Files          64       64              
  Lines        7525     7525              
==========================================
- Hits         4301     4197     -104     
- Misses       2481     2567      +86     
- Partials      743      761      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallyn hallyn merged commit 6af83b9 into project-stacker:main Feb 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants