fix: avoid max read size reached error when cmp imported files #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The equalfile golang package defaults to max read size of 10**10 bytes unless both files use io.LimitedReader to set an upper bound on the read. In stacker import we already stat the two files being compared and know the actual file size. This PR constructs two io.LimitedReader's for each file being compared. Fixes: project-stacker#617 Signed-off-by: Ryan Harper <[email protected]>
mikemccracken
approved these changes
May 8, 2024
raharper
force-pushed
the
fix/large-file-size
branch
from
8a2904b to
dfc4e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#617
What does this PR do / Why do we need it:
when dealing with large files in imports (> 10**10 bytes) then equalfile fails.
this PR uses io.LimitedReader to avoid the error path.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.