Atomfs top

[rchincha]

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.67%. Comparing base (ad9a694) to head (c2c19f0).

Files with missing lines	Patch %	Lines
cmd/stacker/internal_go.go	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ad9a694) and HEAD (c2c19f0). Click for more details.

HEAD has 39 uploads less than BASE

Flag	BASE (ad9a694)	HEAD (c2c19f0)
	40	1

Additional details and impacted files

@@            Coverage Diff            @@
##             main    #652      +/-   ##
=========================================
- Coverage   13.08%   6.67%   -6.41%     
=========================================
  Files          35      57      +22     
  Lines        5084    6445    +1361     
=========================================
- Hits          665     430     -235     
- Misses       4309    5952    +1643     
+ Partials      110      63      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[rchincha]

@mikemccracken looks like some opts := atomfs.MountOCIOpts{ related changes likely broke this?

[rchincha]

2024-11-21T04:51:45.5185091Z not ok 8 mount + umount + mount a tree of images works in 3406ms
2024-11-21T04:51:45.5186133Z # (from function `stacker' in file test/helpers.bash, line 111,
2024-11-21T04:51:45.5188624Z #  in test file test/atomfs.bats, line 101)
2024-11-21T04:51:45.5203134Z #   `stacker internal-go atomfs umount b' failed

024-11-21T04:51:45.5848499Z # mountinfo after b^
2024-11-21T04:51:45.5848771Z # Debug mode:
2024-11-21T04:51:45.5849104Z # stacker version df9884444bf07e2a511c828fed1aebb36baf5b03
2024-11-21T04:51:45.5849929Z # stacker subcommand: [/home/runner/work/stacker/stacker/stacker --debug internal-go atomfs umount b]
2024-11-21T04:51:45.5850993Z # Device /dev/mapper/74dca53d231ebbe7e483abc17cef1f17ecfc7ef4c52352e352ff6789062e88bf-verity is still in use.
2024-11-21T04:51:45.5851918Z # error: libcryptsetup function 'crypt_deactivate' returned error with code '-16'.
2024-11-21T04:51:45.5852451Z # machinerun.io/atomfs/squashfs.Umount
2024-11-21T04:51:45.5856489Z # 	/build/gopath/pkg/mod/github.com/rchincha/[email protected]/squashfs/verity.go:493
2024-11-21T04:51:45.5857390Z # machinerun.io/atomfs.Umount