Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update write base path URLs list to use double quotes #3946

Conversation

akulavasu
Copy link

By default, jinja renders list elements with single quotes which causes below error when used in configmap. The changes in this PR will give double quotes for list elements.

Configuration error: Configuration error[/home/sunbird/assessment-service-1.0-SNAPSHOT/config/application.conf: 431: List should have ended with ] or had a comma, instead had token: ':' (if you want ':' to be part of a string value, then double-quote it)]

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (additive changes to improve performance)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Assessment, Content, Taxonomy pods and verified.

@gandham-santhosh
Copy link
Collaborator

With the current changes we are able to successfully run the microservices in Azure and OCI initialising the cloud storage variables with multiple URL's. If these changes are not working for you, please rebase and raise PR to release-8.0.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants