fix: metrics should be protected behind authZ #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1895 +/- ##
==========================================
- Coverage 91.87% 91.85% -0.03%
==========================================
Files 155 155
Lines 26678 26701 +23
==========================================
+ Hits 24511 24525 +14
- Misses 1603 1611 +8
- Partials 564 565 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andaaron
previously approved these changes
Oct 6, 2023
adodon2go
force-pushed
the
authn-protected-metrics
branch
2 times, most recently
from
ef6f7bd to
e8b1bcb
Compare
adodon2go
requested review from
rchincha and
eusebiu-constantin-petu-dbk
as code owners
andaaron
previously approved these changes
Oct 11, 2023
adodon2go
force-pushed
the
authn-protected-metrics
branch
4 times, most recently
from
fc826a5 to
4ea9451
Compare
adodon2go
force-pushed
the
authn-protected-metrics
branch
from
4ea9451 to
4389c19
Compare
adodon2go
changed the title
adodon2go
force-pushed
the
authn-protected-metrics
branch
2 times, most recently
from
398838f to
7e4f8cb
Compare
andaaron
reviewed
Oct 16, 2023
rchincha
reviewed
Oct 16, 2023
rchincha
reviewed
Oct 16, 2023
adodon2go
force-pushed
the
authn-protected-metrics
branch
3 times, most recently
from
3b01c06 to
6b5fac6
Compare
andaaron
reviewed
Oct 18, 2023
adodon2go
force-pushed
the
authn-protected-metrics
branch
2 times, most recently
from
a208dbc to
823e3f4
Compare
andaaron
previously approved these changes
Oct 18, 2023
rchincha
reviewed
Oct 18, 2023
adodon2go
force-pushed
the
authn-protected-metrics
branch
from
823e3f4 to
e58a871
Compare
andaaron
reviewed
Oct 19, 2023
|
There is a test failure? |
adodon2go
force-pushed
the
authn-protected-metrics
branch
2 times, most recently
from
9a11415 to
0dd615e
Compare
Signed-off-by: Alexei Dodon <[email protected]>
adodon2go
force-pushed
the
authn-protected-metrics
branch
from
0dd615e to
7b1441d
Compare
andaaron
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#1876
What does this PR do / Why do we need it:
In case anonymous policy is present in access control,we allow anonymous users to access to access /metrics endpoints.
To prevent this in accessControl section of config you can specify a list of metrics users that are allowed to access /metrics endpoint.
In case accessControl is not specified in config but auth is present than only authenticated users can access /metrics endpoint
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.