fix(authn): apply fail delay only if credentials/sessions are supplied #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
eusebiu-constantin-petu-dbk
force-pushed
the
fix_faildelay
branch
from
dc60520 to
9ad2843
Compare
Codecov Report
@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
- Coverage 91.94% 91.93% -0.01%
==========================================
Files 153 153
Lines 26437 26437
==========================================
- Hits 24307 24305 -2
- Misses 1573 1574 +1
- Partials 557 558 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andaaron
previously approved these changes
Oct 10, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
fix_faildelay
branch
from
9ad2843 to
e65cf9d
Compare
|
I opened #1923 for the test failure |
rchincha
reviewed
Oct 11, 2023
Signed-off-by: Petu Eusebiu <[email protected]>
eusebiu-constantin-petu-dbk
force-pushed
the
fix_faildelay
branch
from
e65cf9d to
f8d1f8c
Compare
andaaron
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
#1914
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.