Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use runners provided by CNCF #1946

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

rchincha
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adodon2go adodon2go force-pushed the beefy-runners branch 3 times, most recently from 8b77158 to 15ea1bf Compare October 19, 2023 20:27
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1946 (c350bb8) into main (1675f30) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 91.05%.

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
- Coverage   91.86%   91.85%   -0.02%     
==========================================
  Files         155      155              
  Lines       26702    26790      +88     
==========================================
+ Hits        24531    24608      +77     
- Misses       1607     1615       +8     
- Partials      564      567       +3     
Files Coverage Δ
pkg/meta/dynamodb/dynamodb.go 92.62% <100.00%> (+0.02%) ⬆️
pkg/storage/common/common.go 93.05% <94.82%> (+0.15%) ⬆️
pkg/storage/imagestore/imagestore.go 87.03% <81.81%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ramkumar Chinchani <[email protected]>
@rchincha
Copy link
Contributor Author

Not sure if this PR is helping speed up ci though!

@adodon2go
Copy link
Collaborator

It definitely improves speed time: 3x faster running test-extended using this (from 48m->15m)
Also it helps running kind in CI: my prometheus script fails without this change

@adodon2go adodon2go merged commit 4cb7a6c into project-zot:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants