Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test both go 1.20 and 1.21 #2044

Closed
wants to merge 1 commit into from
Closed

Conversation

andaaron
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2a9239) 91.95% compared to head (cdb4e28) 91.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2044      +/-   ##
==========================================
+ Coverage   91.95%   91.97%   +0.01%     
==========================================
  Files         164      164              
  Lines       27657    27657              
==========================================
+ Hits        25433    25438       +5     
+ Misses       1648     1644       -4     
+ Partials      576      575       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andaaron
Copy link
Contributor Author

Looks like the go.mod requires an update when used with Go 1.21.
To keep compatibility with 1.20 we would need to go mod tidy -go=1.20
But we get the error go: github.com/letsencrypt/[email protected] requires [email protected], but 1.20 is requested

Seem unlikely we can keep a single committed version of the go.mod file for both 1.20 and 1.21.

I will close this PR, and will investigate using only version 1.21 for zot release 2.0.1.

@andaaron andaaron closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant