feat: add changing user password route for htpasswd #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onidoru
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
onidoru
force-pushed
the
change_password_route
branch
from
c987ffe to
77652ad
Compare
andaaron
reviewed
Jan 25, 2024
andaaron
reviewed
Jan 31, 2024
andaaron
reviewed
Jan 31, 2024
|
|
||
| username := userAc.GetUsername() | ||
| if username == "" { | ||
| resp.WriteHeader(http.StatusNotFound) |
There was a problem hiding this comment.
This is related to my previous comment: https://github.com/project-zot/zot/pull/2183/files#r1466598996
onidoru
force-pushed
the
change_password_route
branch
from
b79b823 to
46fdc8c
Compare
pkg/api/htpasswd.go
Outdated
| return fmt.Errorf("error occurred while replacing htpasswd file with new file: %w", err) | ||
| } | ||
|
|
||
| err = os.WriteFile(hc.filepath, output, constants.DefaultDirPerms) |
There was a problem hiding this comment.
this should not be needed, right, or am I missing something?
you first write in tmpfile then you rename it to hc.filepath, that should be enough.
andaaron
reviewed
Feb 6, 2024
pkg/api/htpasswd.go
Outdated
| return fmt.Errorf("error occurred while encrypting new password: %w", err) | ||
| } | ||
|
|
||
| file, err := os.ReadFile(hc.filepath) |
There was a problem hiding this comment.
We need a lock to block other users changing their passwords from reading/writing the file at the same time, and only one of the password changes ending up in the file.
onidoru
force-pushed
the
change_password_route
branch
from
63df109 to
5f7370c
Compare
rchincha
reviewed
Feb 7, 2024
| @@ -19,6 +19,7 @@ const ( | |||
| LoginPath = AppNamespacePath + "/auth/login" | |||
| LogoutPath = AppNamespacePath + "/auth/logout" | |||
| APIKeyPath = AppNamespacePath + "/auth/apikey" | |||
| ChangePasswordPath = AppNamespacePath + "/auth/change_password" | |||
|
Cases to take care of:
|
Signed-off-by: onidoru <[email protected]>
Signed-off-by: onidoru <[email protected]>
Signed-off-by: Nikita Kotikov <[email protected]>
Signed-off-by: onidoru <[email protected]>
onidoru
force-pushed
the
change_password_route
branch
from
5f7370c to
bf5bbee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
It adds a feature of changing user password for htpasswd-file authentication.
What does this PR do / Why do we need it:
Issue: #702
Testing done on this change:
Unit testing.
Will this break upgrades or downgrades?
No.
Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.