Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): add tag rejectRegex filter #2906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vooon
Copy link

@vooon vooon commented Jan 23, 2025

What type of PR is this?

feature

Which issue does this PR fix:

Fix #2902

What does this PR do / Why do we need it:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vooon vooon changed the title feat(sync): add tag reject_regex filter feat(sync): add tag rejectRegex filter Jan 23, 2025
@vooon vooon marked this pull request as ready for review January 23, 2025 14:34
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (ececc9c) to head (9be3b6e).

Files with missing lines Patch % Lines
pkg/extensions/sync/content.go 54.16% 8 Missing and 3 partials ⚠️
pkg/cli/server/root.go 0.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2906      +/-   ##
==========================================
- Coverage   91.89%   91.84%   -0.06%     
==========================================
  Files         170      170              
  Lines       30291    30323      +32     
==========================================
+ Hits        27836    27849      +13     
- Misses       1827     1842      +15     
- Partials      628      632       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also add an example under examples/

@vooon For your particular use case, are you sure there is no workaround that can avoid this PR altogether.

Regex *string
Semver *bool
Regex *string
RejectRegex *string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would call this "ExcludeRegex"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Sync tags rejection regex
3 participants