Adding localization #445
Adding localization #445
Conversation
Future998
commented
Oct 25, 2024
Future998
commented
- Replaced the text for localization.
- Added Select to select the language in the Header.
- Localization of the DateTime format.
- Added Russian language.
|
@Future998 thanks for the PR. |
|
|
|
@Future998 seems to be working nicely. Can you pls rebase and fix the merge conflicts? |
Future998
force-pushed
the
localization
branch
from
856bca3 to
8f170a3
Compare
|
@Future998 pls address the ci failures. |
Future998
force-pushed
the
localization
branch
4 times, most recently
from
3dd802a to
0eef473
Compare
|
@rchincha, OK, it's ready |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 85.00% 84.25% -0.76%
==========================================
Files 63 64 +1
Lines 1961 2039 +78
Branches 532 541 +9
==========================================
+ Hits 1667 1718 +51
- Misses 284 308 +24
- Partials 10 13 +3 ☔ View full report in Codecov by Sentry. |
|
I don't quite understand what to do next? |
Future998
force-pushed
the
localization
branch
2 times, most recently
from
4f37f4e to
73b21a5
Compare
|
@rchincha, OK, it's ready |
|
@Future998 This PR is a little late for the very next release. Will consider this for the next release after. |
|
|
||
| const { t, i18n } = useTranslation(); | ||
| const [selectedLanguage, setSelectedLanguage] = useState(i18n.language); | ||
| const handleLanguageChange = (event) => { |
There was a problem hiding this comment.
A test with language selection would be good to have, just to have it covered as it would be a new feature
- Replaced the text for localization. - Added Select to select the language in the Header. - Localization of the DateTime format. - Added Russian language. Signed-off-by: Alexander Burmatov <[email protected]>
The translation of the application affected the tests. Signed-off-by: Alexander Burmatov <[email protected]>
Signed-off-by: Alexander Burmatov <[email protected]>
Future998
force-pushed
the
localization
branch
from
73b21a5 to
384723a
Compare
|
Like that? |
