This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
fsv: always check for the presence/usage of firewalld #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the Atomic Host streams should now have `firewalld` installed, so let's remove the conditionals and always check that it is there.
|
Requires CentOS/sig-atomic-buildscripts#340 |
|
LGTM. Will merge this after CentOS/sig-atomic-buildscripts#340 is merged |
|
@mike-nguyen That change got merged and last CAHC compose included the files. I'm gonna kick off both CentOS checks to see how it goes. |
|
Meh...the The Looks like I need to make another PR... |
|
I cleaned up the docker storage driver stuff in #421. @mike-nguyen you can merge that first or this one...I think both changes are pretty low risk. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the Atomic Host streams should now have
firewalldinstalled,so let's remove the conditionals and always check that it is there.