CAPZ Win FV fixes #9150
Merged
CAPZ Win FV fixes #9150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutinhop
added
docs-not-required
Add timeout and retry to command that waits for CAPZ deployments. Move process/testing/winfv to process/testing/winfv-felix and adjust scripts accordingly. Add RELEASE_STREAM=local option to use local manifests and make CI runs use it.
coutinhop
force-pushed
the
pedro-winfv-capz-1
branch
from
afcd348
to
9c1d32e
Compare
hjiawei
reviewed
Aug 22, 2024
…clusters). Update resource group and managed identity required for CAPZ machinepool-windows template. General updates to CAPZ Win FV scripts.
song-jiang
reviewed
Aug 29, 2024
metadata.mk
Outdated
| KINDEST_NODE_VERSION=v1.29.7 | ||
| KIND_VERSION=v0.22.0 | ||
| KINDEST_NODE_VERSION=v1.29.2 | ||
| KINDEST_NODE_VERSION_CAPZ=v1.28.9 |
There was a problem hiding this comment.
I'm thinking of disassociating the kind version used in capz from the general kind version in metadata.mk,
Agree. I feel we should keep all capz configurations to process/testing/winfv-felix/capz/ directory. It would be easier to maintain.
| @@ -17,13 +20,14 @@ export AZURE_NODE_MACHINE_TYPE="${AZURE_NODE_MACHINE_TYPE:="Standard_D2s_v3"}" | |||
| SCRIPT_CURRENT_DIR="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 && pwd -P )" | |||
| METADATAMK=${SCRIPT_CURRENT_DIR}/../../../../metadata.mk | |||
| if [ -f "${METADATAMK}" ]; then | |||
| export KUBE_VERSION=$(grep KINDEST_NODE_VERSION= ${METADATAMK} | cut -d "=" -f 2) | |||
| export KUBE_VERSION=$(grep KINDEST_NODE_VERSION_CAPZ= ${METADATAMK} | cut -d "=" -f 2) | |||
| export KIND_VERSION=$(grep KIND_VERSION= ${METADATAMK} | cut -d "=" -f 2) | |||
There was a problem hiding this comment.
As I commented above, I think we should remove this section of the code where kind_version is derived from metadata.mk.
coutinhop
added a commit
to coutinhop/calico
that referenced
this pull request
Sep 17, 2024
* CAPZ Win FV fixes Add timeout and retry to command that waits for CAPZ deployments. Move process/testing/winfv to process/testing/winfv-felix and adjust scripts accordingly. Add RELEASE_STREAM=local option to use local manifests and make CI runs use it. * Fix package versions and fix azure identity authentication * Set required env vars for machinepool-windows template * Set k8s kindest/node version to v1.28.9 (v1.29 currently breaks CAPZ clusters). Update resource group and managed identity required for CAPZ machinepool-windows template. General updates to CAPZ Win FV scripts. * Fix incorrect PRODUCT in setup-fv-capz.sh * Use specific kind and kindest/node versions in CAPZ instead of metadata.mk
coutinhop
added a commit
that referenced
this pull request
Sep 18, 2024
* Update k8s to v1.28.14 * Update kubectl download URL * Use ASO as windows cni-plugin fv infrastructure (#8863) * Fix windows cni-plugin fv to use correct apiserver port number (#8955) * CAPZ Win FV fixes (#9150) * CAPZ Win FV fixes Add timeout and retry to command that waits for CAPZ deployments. Move process/testing/winfv to process/testing/winfv-felix and adjust scripts accordingly. Add RELEASE_STREAM=local option to use local manifests and make CI runs use it. * Fix package versions and fix azure identity authentication * Set required env vars for machinepool-windows template * Set k8s kindest/node version to v1.28.9 (v1.29 currently breaks CAPZ clusters). Update resource group and managed identity required for CAPZ machinepool-windows template. General updates to CAPZ Win FV scripts. * Fix incorrect PRODUCT in setup-fv-capz.sh * Use specific kind and kindest/node versions in CAPZ instead of metadata.mk * Merge pull request #9065 from coutinhop/pedro-CORE-10548 [CORE-10548] Revert windows endpoint mgr logic change * Use v3.28 release stream for felix win fvs --------- Co-authored-by: Song Jiang <[email protected]> Co-authored-by: marvin-tigera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeout and retry to command that waits for CAPZ deployments.
Move process/testing/winfv to process/testing/winfv-felix and adjust scripts accordingly.
Add RELEASE_STREAM=local option to use local manifests and make CI runs use it.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.