[BPF] disable conntrack bypass, exclude link-local #9159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
tomastigera
force-pushed
the
tomas-bpf-fix-notrack
branch
2 times, most recently
from
5f2b9cf to
966dba6
Compare
tomastigera
added
docs-not-required
tomastigera
force-pushed
the
tomas-bpf-fix-notrack
branch
from
3176362 to
b77e4f3
Compare
Given the fact that since kernel 5.9+ when FIB is enabled (always except if ipip is used) we always bypass iptables for forwarded traffic, we no longer have the confusing half-open conntrack entries because the first packet would sometimes go through host net stack and then the rest would bypass it. And since most deployments do not use kernels older than 5.9 it is not a common requirement to bypass conntrack. Therefore the default setting it not to do that. However, it is still possible to turn it on via bpfHostConntrackBypass. Some environments like MKE require this to be turned off to function correctly. Also link-local addresses destinations should not be excluded. fixes projectcalico#9157
tomastigera
force-pushed
the
tomas-bpf-fix-notrack
branch
from
b77e4f3 to
02a1c33
Compare
sridhartigera
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the fact that since kernel 5.9+ when FIB is enabled (always except if ipip is used) we always bypass iptables for forwarded traffic, we no longer have the confusing half-open conntrack entries because the first packet would sometimes go through host net stack and then the rest would bypass it. And since most deployments do not use kernels older than 5.9 it is not a common requirement to bypass conntrack. Therefore the default setting it not to do that. However, it is still possible to turn it on via bpfHostConntrackBypass. Some environments like MKE require this to be turned off to function correctly.
Also link-local addresses destinations should not be excluded.
fixes #9157
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.