Add support for BaselineAdminNetworkPolicy. #9464
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
fasaxc
force-pushed
the
banp
branch
8 times, most recently
from
526d489
to
568c1c2
Compare
fasaxc
changed the title
mazdakn
reviewed
Nov 20, 2024
| OssNetworkPolicyNamePrefix = "ossg." | ||
| K8sNetworkPolicyNamePrefix = "knp.default." | ||
| K8sAdminNetworkPolicyNamePrefix = "kanp.adminnetworkpolicy." | ||
| K8sBaselineAdminNetworkPolicyNamePrefix = "kbanp.adminnetworkpolicy." |
There was a problem hiding this comment.
This prefix should be kbanp.baselineadminnetworkpolicy. This is long, but basically the second part baselineadminnetworkpolicy is the tier name.
There was a problem hiding this comment.
If we want to make it shorter, maybe we can name the tier baselinenetworkpolicy and this prefix kbanp.baselinenetworkpolicy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for sig-network-policy-api's BaselineAdminNetowrkPolicy.
Related issues/PRs
CORE-10800
Builds on ANP work:
Tier support: #9085
Default action in tiers: #9232
AdminNetworkPolicy: #9206
AdminNetworkPolicy egress networks: #9276
AdminNetworkPolicy named port: #9254
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.