Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint code and improve linter settings #7

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

maxgio92
Copy link
Collaborator

@maxgio92 maxgio92 commented Jan 29, 2024

This PR introduces linting of the code, and:

  • Set allowed modules explicitely with depguard
  • Add missing license header.
  • Fix GCI referenced project go module name.

@maxgio92 maxgio92 force-pushed the chore/lint-code branch 3 times, most recently from ce712f4 to 13f74cb Compare January 30, 2024 21:44
Besides lint of the code this commit introduces:
- Explicit allowed modules with depguard
- Add missing license header.
- Fix GCI referenced project go module name.

Signed-off-by: Massimiliano Giovagnoli <[email protected]>
@maxgio92 maxgio92 changed the title chore(.golangci.yml): declare allowed packages Lint and improve linter configuration Jan 30, 2024
@maxgio92 maxgio92 changed the title Lint and improve linter configuration chore: lint and improve linter configuration Jan 30, 2024
@maxgio92 maxgio92 changed the title chore: lint and improve linter configuration chore: lint code and improve linter configuration Jan 30, 2024
@maxgio92 maxgio92 changed the title chore: lint code and improve linter configuration chore: lint code and improve linter settings Jan 30, 2024
@maxgio92 maxgio92 marked this pull request as ready for review January 30, 2024 21:54
@maxgio92 maxgio92 requested a review from prometherion January 30, 2024 21:54
@maxgio92
Copy link
Collaborator Author

Hey @prometherion, we can also here ignore Codecov failure - need to address a fix in a dedicated PR.

@maxgio92 maxgio92 merged commit 9788e83 into projectcapsule:main Feb 4, 2024
10 of 14 checks passed
@maxgio92 maxgio92 deleted the chore/lint-code branch February 4, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants