Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for service account bound tokens expiration #566

Conversation

ppodevlabs
Copy link
Contributor

Fixes #565

From kubernetes 1.30 kubelet takes care of renewing tokens for service accounts inside the projected volumes. This PR make capsule-proxy to reload the token when required.

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix, I really appreciated it! 💯

@prometherion
Copy link
Member

@ppodevlabs please, may I ask you to rebase this to get it merged? Thanks!

@ppodevlabs ppodevlabs force-pushed the fix/support-bound-token-expiration branch from c04a43b to a0b22b7 Compare November 11, 2024 21:17
dependabot bot and others added 2 commits November 11, 2024 23:46
…ojectcapsule#554)

Bumps [zgosalvez/github-actions-ensure-sha-pinned-actions](https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions) from 3.0.14 to 3.0.15.
- [Release notes](https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions/releases)
- [Commits](zgosalvez/github-actions-ensure-sha-pinned-actions@40ba2d5...ed00f72)

---
updated-dependencies:
- dependency-name: zgosalvez/github-actions-ensure-sha-pinned-actions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Pedro Parra Ortega <[email protected]>
Signed-off-by: Pedro Parra Ortega <[email protected]>

chore: added missing file

Signed-off-by: Pedro Parra Ortega <[email protected]>

chore: lint

Signed-off-by: Pedro Parra Ortega <[email protected]>

chore: lint file

Signed-off-by: Pedro Parra Ortega <[email protected]>
@ppodevlabs ppodevlabs force-pushed the fix/support-bound-token-expiration branch from a4d4450 to 245b6a5 Compare November 11, 2024 22:47
Signed-off-by: Pedro Parra Ortega <[email protected]>
Signed-off-by: Pedro Parra Ortega <[email protected]>
…ch-labs/capsule-proxy into fix/support-bound-token-expiration
@ppodevlabs
Copy link
Contributor Author

closing this one, i'll create a new one

@ppodevlabs ppodevlabs closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy not working after 1h
2 participants