feat(helm): introduce new installation and CRD lifecycle #1065
+2,444
−1,843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
maxgio92
reviewed
May 7, 2024
maxgio92
reviewed
May 7, 2024
|
Hi @oliverbaehler, what do you think about the method with a job that giantswarm uses to update crds - https://github.com/giantswarm/kube-prometheus-stack-app/tree/a8315a8/helm/prometheus-operator-app/templates/crd-install. Seems like that will help to achieve what you want, but will be completely backward-compatible. |
|
+1 for @MaxFedotov approach, it's the same approach used by HAProxy Technologies for their Kubernetes Ingress Controller. |
oliverbaehler
force-pushed
the
feat/crd-ditribution
branch
2 times, most recently
from
7b2b19d
to
da8b89f
Compare
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
oliverbaehler
force-pushed
the
feat/crd-ditribution
branch
2 times, most recently
from
468793c
to
f239f47
Compare
Signed-off-by: Oliver Bähler <[email protected]>
oliverbaehler
force-pushed
the
feat/crd-ditribution
branch
from
f239f47
to
842eb3b
Compare
Signed-off-by: Oliver Bähler <[email protected]>
prometherion
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we are addressing the distribution of our CRDs and are trying to reconcile the Helm Chart as the main way of installing Capsule. With this change we can keep our overheads little and focus on one way of distribution. While implementing the CRDs i also did some refactoring of certain helm values.
Implements: