Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): use ownerreferences without controller owner relation #1095

Merged
merged 1 commit into from
May 27, 2024

Conversation

oliverbaehler
Copy link
Collaborator

@oliverbaehler oliverbaehler commented May 27, 2024

This changes the fundamental behavior regarding namespace reconcilation. I stumbeled across this while automating against a platform, which creates namespaces for each cluster and adds controller references to the namespace. Since you can only have one controller reference per namespace, such a setup won't work.

With this change, instead of reconciling on the namespaces which are owned by the controller, we reconcile all the namespaces which have a tenant ownerreference.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 0ad0956
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/665463f388f2810008d20cf5

@oliverbaehler oliverbaehler changed the title feat: multiple ownerreferences fix(controller): use ownerreferences without controller owner relation May 27, 2024
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd say the controller reference here is more correct compared to the owner reference since we're not generating the object upon the Tenant creation.

@oliverbaehler oliverbaehler merged commit 4afcfbb into projectcapsule:main May 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants