-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed DNS resolving A records when -ports is set #1347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
added
the
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
label
Sep 7, 2023
ehsandeep
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kz0ltan thank you for fixing this issue!
ehsandeep
requested review from
Mzack9999
and removed request for
tarunKoyalwar
September 11, 2023 22:22
ehsandeep
added
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Sep 12, 2023
Mzack9999
approved these changes
Sep 13, 2023
ehsandeep
removed
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Sep 13, 2023
ehsandeep
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS A records were not showing up in the JSON output if -ports was used or the port was added to the target domain name via -u or -l in <domain_name>: format.
The original code tried to use getDNSData with the URL.Host property which in the above cases included the port specification as well, so the DNS query failed, and no A records were added to the output.
This small change fixes that problem.
Before:
After: