Adding initial support for tls version enum #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
Status: In Progress
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err != nil { | ||
| return nil, errors.Wrap(err, "could not get tls ciphers") | ||
| } | ||
| c.tlsConfig.CipherSuites = customCiphers |
Check failure
Code scanning / CodeQL
Insecure TLS configuration
Mzack9999
added
Status: Review Needed
ehsandeep
requested changes
Aug 8, 2022
| @@ -55,7 +55,7 @@ | |||
| } | |||
|
|
|||
| if options.AllCiphers { | |||
| c.tlsConfig.CipherSuites = allCiphers | |||
| c.tlsConfig.CipherSuites = AllCiphers | |||
Check failure
Code scanning / CodeQL
Insecure TLS configuration
|
SonarCloud Quality Gate failed. |
ehsandeep
approved these changes
Aug 10, 2022
Ice3man543
approved these changes
Aug 10, 2022
ehsandeep
removed
the
Status: Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for:
Follow up investigation tickets
Example
{ "timestamp": "2022-08-08T10:18:47.2387684+02:00", "host": "hackerone.com", "ip": "104.16.100.52", "port": "443", "probe_status": true, "tls_version": "tls13", "cipher": "TLS_AES_128_GCM_SHA256", "not_before": "2022-02-21T00:00:00Z", "not_after": "2023-03-24T23:59:59Z", "subject_dn": "CN=hackerone.com, O=HackerOne Inc., L=San Francisco, ST=California, C=US, serialNumber=5308693, businessCategory=Private Organization, jurisdictionStateOrProvince=Delaware, jurisdictionCountry=US, businessCategory=Private Organization, jurisdictionStateOrProvince=Delaware, jurisdictionCountry=US", "subject_cn": "hackerone.com", "subject_org": [ "HackerOne Inc." ], "subject_an": [ "hackerone.com", "www.hackerone.com", "api.hackerone.com" ], "issuer_dn": "CN=DigiCert SHA2 Extended Validation Server CA, OU=www.digicert.com, O=DigiCert Inc, C=US", "issuer_cn": "DigiCert SHA2 Extended Validation Server CA", "issuer_org": [ "DigiCert Inc" ], "fingerprint_hash": { "md5": "f26c9c2b1f0a75f9419c09bd57c84e41", "sha1": "9118c928a478899b5d4e18e7bacc438c994e1299", "sha256": "61dcdf3ff2bc9ccd545fd19f6783ac8cb13c06fdaac32212e8bc1b52c2e327b0" }, "tls_connection": "ctls", "sni": "hackerone.com", "version-enum": [ "tls13", "tls12" ], "cipher-enum": [ { "version": "tls13", "ciphers": [ "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256", "TLS_FALLBACK_SCSV", "TLS_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_RC4_128_SHA", "TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA", "TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA", "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256", "TLS_AES_256_GCM_SHA384", "TLS_RSA_WITH_AES_128_CBC_SHA", "TLS_RSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA", "TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA", "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305", "TLS_RSA_WITH_AES_256_GCM_SHA384", "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384", "TLS_RSA_WITH_3DES_EDE_CBC_SHA", "TLS_RSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_ECDSA_WITH_RC4_128_SHA", "TLS_CHACHA20_POLY1305_SHA256", "TLS_RSA_WITH_RC4_128_SHA", "TLS_RSA_WITH_AES_256_CBC_SHA", "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384", "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305" ] }, { "version": "tls12", "ciphers": [ "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256", "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256", "TLS_AES_256_GCM_SHA384", "TLS_RSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA", "TLS_RSA_WITH_AES_256_GCM_SHA384", "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384", "TLS_ECDHE_ECDSA_WITH_RC4_128_SHA", "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384", "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305" ] } ] }