Preserve file ownership when rewriting input ebuild #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorny
reviewed
Oct 9, 2024
pycargoebuild/__main__.py
Outdated
| @@ -397,6 +397,8 @@ def repack_crates(tar_out: tarfile.TarFile, | |||
| delete=False) as outf: | |||
| try: | |||
| if args.input is not None: | |||
| st = os.stat(args.input.fileno()) | |||
| os.chown(outf.fileno(), st.st_uid, st.st_gid) | |||
| # typeshed is missing fd support in shutil.copymode() | |||
| # https://github.com/python/typeshed/issues/9288 | |||
| shutil.copymode(args.input.fileno(), | |||
There was a problem hiding this comment.
Since you're doing a stat() now, let's replace this with os.chmod() as well.
There was a problem hiding this comment.
Done. This lets us totally get rid of the shutil import, too...
If `sudo pycargoebuild` is used, e.g. to store downloaded crates in /var/cache/distfiles, the ebuild file ends up chowned to root since it is atomically rewritten. Explicitly chown it back. Signed-off-by: Eli Schwartz <[email protected]>
After the previous commit, this is our only use of shutil, which provides a "portable wrapper for chmod" (assuming we needed Windows support) and doesn't actually have type safety since typeshed doesn't accept the use of file descriptors since it isn't documented and won't work with follow_symlinks=False... that we don't use. The regular os functions are simpler and type-safe, so let's just use it. Signed-off-by: Eli Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
sudo pycargoebuildis used, e.g. to store downloaded crates in /var/cache/distfiles, the ebuild file ends up chowned to root since it is atomically rewritten. Explicitly chown it back.