Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add consul_exporter role #514

Merged
merged 12 commits into from
Feb 7, 2025
Merged

Conversation

anviar
Copy link
Contributor

@anviar anviar commented Jan 15, 2025

Add new role: consul_exporter

Signed-off-by: Oleg Klyuchkin <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure you follow the tagging convention below (to be documented in the README soon):

  • Functional Tags: General-purpose tags for task behavior, e.g., download, install, configure, etc.
  • Role-Scoped Functional Tags: Combine the role name with a functional tag, e.g., <role_name>_download, <role_name>_install, etc.
  • Role-Wide Tags: Represent the entire role, e.g., <role_name>.

This structure allows for granular control, enabling you to target or skip tasks across all roles (e.g., all download tasks) or within a specific role (e.g., only <role_name>_download tasks).

@github-actions github-actions bot added enhancement New feature or request roles/consul_exporter and removed enhancement New feature or request labels Jan 15, 2025
Co-authored-by: gardar <[email protected]>
Signed-off-by: Oleg Klyuchkin <[email protected]>
@github-actions github-actions bot removed the enhancement New feature or request label Jan 15, 2025
Co-authored-by: gardar <[email protected]>
Signed-off-by: Oleg Klyuchkin <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
Co-authored-by: gardar <[email protected]>
Signed-off-by: Oleg Klyuchkin <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Jan 15, 2025
anviar and others added 2 commits January 15, 2025 17:56
Co-authored-by: gardar <[email protected]>
Signed-off-by: Oleg Klyuchkin <[email protected]>
Co-authored-by: gardar <[email protected]>
Signed-off-by: Oleg Klyuchkin <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
@anviar anviar requested a review from gardar January 16, 2025 10:19
@gardar
Copy link
Member

gardar commented Jan 19, 2025

Re-triggered the failing lint job as ansible-compat 25.0.0 has been yanked and it seems to be passing now, see ansible/ansible-lint#4477

@anviar can you please take a look at the alternative molecule scenario that's failing now?

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 23, 2025
@github-actions github-actions bot removed the enhancement New feature or request label Jan 23, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 23, 2025
@anviar
Copy link
Contributor Author

anviar commented Jan 23, 2025

@gardar looks like fixed for now...

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 27, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 28, 2025
Co-authored-by: gardar <[email protected]>
Signed-off-by: Oleg Klyuchkin <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 31, 2025
@anviar anviar requested a review from gardar January 31, 2025 09:10
@gardar gardar merged commit 48882be into prometheus-community:main Feb 7, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants