-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add check_mode to the checksum task #524
fix: add check_mode to the checksum task #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps check_mode: false
should be applied to the whole binary download block?
We can do that as well. |
Signed-off-by: Santiago Lo Coco <[email protected]>
Signed-off-by: Santiago Lo Coco <[email protected]>
53612bd
to
859a4f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds the
check_mode: false
in the fetch checksum task.This is needed because the next task, which parses the checksum list, expects the checksum files to already be downloaded. Without
check_mode: false
, the task only runs in "simulation" mode and doesn't download the files.This "bug" was introduced during a refactor: 6209b53
Without
check_mode: false
:With
check_mode: false
: