feat: add cluster license collector #833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kekkokers <[email protected]>
kekkker
force-pushed
the
feat/add-cluster-license
branch
from
5e4d4a9
to
617e127
Compare
sysadmind
requested changes
Dec 11, 2023
Signed-off-by: kekkokers <[email protected]>
kekkker
force-pushed
the
feat/add-cluster-license
branch
from
3a30e6f
to
0c74085
Compare
Signed-off-by: kekkokers <[email protected]>
Signed-off-by: kekkokers <[email protected]>
Signed-off-by: kekkokers <[email protected]>
kekkker
force-pushed
the
feat/add-cluster-license
branch
from
ee49b46
to
e283dcc
Compare
Signed-off-by: kekkokers <[email protected]>
kekkker
force-pushed
the
feat/add-cluster-license
branch
from
14e324b
to
365715f
Compare
|
Hello @sysadmind, Thank you for the feedback! Everything has been implemented; let me know if there's anything else to be done. Thanks! |
Signed-off-by: kekkokers <[email protected]>
sysadmind
reviewed
Dec 21, 2023
| } | ||
|
|
||
| var ( | ||
| defaultClusterLicenseLabels = []string{"issued_to", "issuer", "type", "status"} |
There was a problem hiding this comment.
@SuperQ What do you think of these labels? type and status seem like normal labels, but I'm not sure about issued_to or issuer. I'm not sure that they cause any harm here, but I'm not sure of the tradeoffs.
|
|
||
| u := *c.u | ||
| u.Path = path.Join(u.Path, "/_license") | ||
| res, err := c.hc.Get(u.String()) |
There was a problem hiding this comment.
Most of this code can be removed and use the getURL() func.
https://github.com/prometheus-community/elasticsearch_exporter/blob/master/collector/util.go#L26
https://github.com/prometheus-community/elasticsearch_exporter/blob/master/collector/snapshots.go#L119-L127
| @@ -263,6 +263,10 @@ Further Information | |||
| | elasticsearch_data_stream_stats_json_parse_failures | counter | 0 | Number of parsing failures for Data Stream stats | | |||
| | elasticsearch_data_stream_backing_indices_total | gauge | 1 | Number of backing indices for Data Stream | | |||
| | elasticsearch_data_stream_store_size_bytes | gauge | 1 | Current size of data stream backing indices in bytes | | |||
| | elasticsearch_cluster_license_expiry_date_seconds | gauge | 1 | License expiry date since unix epoch in second s | | |||
There was a problem hiding this comment.
Suggested change
| | elasticsearch_cluster_license_expiry_date_seconds | gauge | 1 | License expiry date since unix epoch in second s | | |
| | elasticsearch_cluster_license_expiry_date_seconds | gauge | 1 | License expiry date since unix epoch in seconds | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.