Add fail_if_body_too_large http probe option
#1276
Conversation
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
81b9317 to
1e0ff2b
Compare
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
1e0ff2b to
2d225ab
Compare
|
Do you want any changes here? Or is this a feature you don't want merged? |
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
2a3f154 to
1512b95
Compare
|
can you share more on the use-case? and what problem this flag will solve? once I better understand the "why?" behind the change, I will find some time to review. |
At work, we need to probe endpoints that endlessly stream data. Without this flag every probe will fail after some time, since Blackbox Exporter expects the data stream to finish otherwise. We want to measure successful requests and "time to X bytes". |
|
please rebase to fix the failing CI. |
This can be used in conjunction with `body_size_limit` when it is expected that endpoints return a body larger than the specified limit, e.g. streaming endpoints that potentially return infinite data. Signed-off-by: Justin Kromlinger <[email protected]>
Signed-off-by: Justin Kromlinger <[email protected]>
Signed-off-by: Justin Kromlinger <[email protected]>
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
081a0e3 to
137226a
Compare
|
Sorry for the delay, added the requested changes. |
Signed-off-by: Justin Kromlinger <[email protected]>
Signed-off-by: Justin Kromlinger <[email protected]>
Signed-off-by: Justin Kromlinger <[email protected]>
hashworks
force-pushed
the
feature/fail_if_body_too_large
branch
from
137226a to
f309195
Compare
|
Fixed the DCO CI failures. |
|
I don't think the test failures are related to my changes. Are they green on master? |
yes, try rebasing on the latest main. |
|
Hm... the branch is up2date. |
This can be used in conjunction with
body_size_limitwhen it is expected that endpoints return a body larger than the specified limit, e.g. streaming endpoints that potentially return infinite data.