Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate behaviour of DirectFileStore in the presence of existing files #109

Open
Sinjo opened this issue May 1, 2019 · 2 comments
Open

Comments

@Sinjo
Copy link
Member

Sinjo commented May 1, 2019

We (GoCardless) run our services in containers, which means a clean file system every time we boot the app.

We should look at what the behaviour is like for people who have file systems that persist between versions of the app. If so, we should look at what mitigations we can implement to make DirectFileStore work by default.

Any edge-cases should be added to the DirectFileStore’s docs.

@dmagliola
Copy link
Collaborator

See Lawrence's comment on file locking as a potential way of knowing which files are still owned by living processes.

#143 (comment)

Valid warning from Brian that it may not work in all OSes, plus we can't just delete "some" files, but this may be an idea to start building a solution around

@Sinjo Sinjo removed their assignment Jul 11, 2019
@Sinjo Sinjo removed this from the v0.10.0 milestone Aug 19, 2019
@Sinjo
Copy link
Member Author

Sinjo commented Aug 19, 2019

Similar to #143, and for the same reasons outlined in this comment, I'm taking this out of the v0.10.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants