Improve documentation for DirectFileStore #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmagliola
force-pushed
the
improved_documentation
branch
2 times, most recently
from
5d5961d to
67b4ab5
Compare
The main changes are documenting some important caveats that are relevant when running DirectFileStore in production, and the `ALL` aggregation method for Gauges Signed-off-by: Daniel Magliola <[email protected]>
dmagliola
force-pushed
the
improved_documentation
branch
from
67b4ab5 to
81222d3
Compare
1 similar comment
This was referenced Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are documenting some important caveats that are relevant
when running DirectFileStore in production, and the
ALLaggregationmethod for Gauges