Prombench: tweak rw-sink resource usage #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Boreham <[email protected]>
bwplotka
approved these changes
Nov 27, 2024
|
This is 1M series scraped every 5s, on two Prometheus. So 400K samples/sec? I'm not very sure what you mean about limiting concurrency. We use 8-core nodes, so it won't be more than that. |
|
I mean we can add limit of the concurrency on sink, so it receives slower, but with stable CPU use. But you are right that a lot of it was through GC. I will also play with memory regions (new proposal) to reduce GC. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the sink program handles a lot of messages but doesn't do anything with them, it does a lot of garbage-collection.
Tell the Go runtime we would like it to use more memory, which reduces the CPU by about half.
Adjust requests to match.