Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/2023 09 28 updates and fixes #134

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

BaxterEaves
Copy link
Contributor

  • Fixed some broken links the the book
  • Fixed non-working code in the README (used old pylace conventions)
  • Added back the light theme to book since some windows users were experiencing low contrast with the latte theme
  • Added some example use cases to the README
  • Added output figures to the README

@BaxterEaves BaxterEaves added the documentation Improvements or additions to documentation label Sep 28, 2023
@BaxterEaves BaxterEaves requested a review from a team as a code owner September 28, 2023 14:33
@BaxterEaves BaxterEaves mentioned this pull request Sep 28, 2023
Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some thoughts, but not enough to hold approval. LGTM!

performance, EKG data, and other clinical data. Combined, this data would
typically be very sparse (most patients will not have all fields filled
in), and it is difficult to know how to explicitly model the interaction of
these data layers. In Lace, we would just concatenate the layers and run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Concatenate the layers and pull them through"-i don't understand this, it sounds too simple-like how could it be that easy? Maybe a rewording that explains why you can't do that yourself? Or maybe I'm not getting it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is that easy 😉


```console
Lace requires rust.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylace shouldn't require Rust if you install it with pip

@BaxterEaves BaxterEaves merged commit c4c9464 into master Sep 29, 2023
19 checks passed
@BaxterEaves BaxterEaves deleted the docs/2023-09-28-updates-and-fixes branch September 29, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants