Bugfix/license cleanup #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License identifiers are mostly maintained by Spdx; their list of identifiers is here: https://spdx.github.io/license-list-data/ According to the above page, the correct identifier for the Business Source License is `BUSL-1.1` This commit updates the license on all crates Each crate that is being published under a new license is given a MAJOR semver change Each crate that is being published under the same license, but using the SPDX instead of a license file, is given a MINOR semver change
Testing workflows are running on pushes to master, and it isn't necessary Everything has to go through a pull request anyway, so the extra testing is superfluous and confusing
Changed the CITATION check to only run on release pushes Added a check to make sure the `date-released` field gets updated from the last release Restored the prior date-released in the CITATION.cff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect this to fail, due to some things being deliberately wrong in
CITATION.cffandCHANGELOG.mdthat should be updated when the answers are figured out. Meanwhile, these are some things I thought should change as I was releasing Lace0.5.0:BSL-1.1(which is not a valid SPDX identifier) toBUSL-1.1. The SPDX entry forBUSL-1.1is here; I think it's the correct one for our Business Source License, despite the fact that within our license the acronym BSL is used. But @BaxterEaves , I would appreciate it if you verified that theBUSL-1.1identifier looks like the correct one; otherwise, we can uselicense-fileto specify our includedLICENSEinsteadCargo.tomlfiles withlicense-file = LICENSEto instead uselicense = BUSL-1.1. I considered this to be a MINOR semver changes because they should be the same license, just expressed in different ways. Semver did not appear to be clear on this issue.Cargo.tomlfiles withlicense = SSPL-1.0to instead belicense = BUSL-1.1. This list essentially is all the dependency crates oflace. I considered all of these changes to be MAJOR changes, since the license is changing.CITATION.CFFfilemaster--only on PRs