-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/explain pred #158
Feature/explain pred #158
Conversation
d2e6486
to
ad5843b
Compare
a8c40fa
to
ce69065
Compare
.chain(f2.components().iter()) | ||
.map(|cpnt| (cpnt.mu(), cpnt.sigma())) | ||
.collect::<Vec<_>>(); | ||
params.sort_unstable_by(|(a, _), (b, _)| a.total_cmp(b)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned something here! I didn't know about f64::total_cmp
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see anything that looked like a problem, so LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 Done! Looks great!
41ad2a5
to
696c14d
Compare
9b5bdcc
to
ac4a303
Compare
ac4a303
to
1e14eaa
Compare
Added
plot.state
function in pylace to render PCC statesanalysis.explain_prediction
in pylace to explain predictionsplot.prediction_explanation
in pylace to render prediction explanationsanalysis.held_out_uncertainty
in pylaceanalysis.attributable_[neglogp | inconsistrncy | uncertainty]
in pylace to quantify the amount of surprisal (neglogp), inconsistency, and uncertainty attributable to other featuresChanged
logsumexp
in favor ofrv::misc::logsumexp
(n-1) / n
, wheren
is the number of states. This normalization is meant to ensure that the interpretation is the same regardless of the number of states -- zero is lowest, one is highest.Fixed