Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Added tqdm handler for Engine.update progress bar. #176

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

schmidmt
Copy link
Contributor

@schmidmt schmidmt commented Feb 1, 2024

The API for the Python binding did not change outside the lace.core module.

This allows for a progress bar to be called and updated like Lace::UpdateHandler in lace.core.update. Here, the default is to use tqdm.auto.

This addresses #173.

@schmidmt schmidmt self-assigned this Feb 1, 2024
@schmidmt schmidmt requested a review from a team as a code owner February 1, 2024 20:11
@schmidmt schmidmt linked an issue Feb 1, 2024 that may be closed by this pull request
@schmidmt schmidmt added enhancement New feature or request Python Pertains to the Python API labels Feb 1, 2024
The API for the python binding did not change outside the `lace.core` module.

This allows for a progress bar to be called and updated like `Lace::UpdateHandler` in `lace.core.update`. Here, the default is to use `tqdm.auto`.
@schmidmt schmidmt force-pushed the feature/pylace-update-handler branch from 3b293f4 to 60e9a7d Compare February 1, 2024 20:35
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple of questions, but I legitimately don't know if they are problems, so I have no concerns with merging this. LGTM!

pylace/src/lib.rs Show resolved Hide resolved
pylace/src/update_handler.rs Show resolved Hide resolved
@schmidmt schmidmt requested a review from Swandog February 1, 2024 22:43
@schmidmt schmidmt merged commit 9135670 into master Feb 1, 2024
11 checks passed
@schmidmt schmidmt deleted the feature/pylace-update-handler branch May 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Pertains to the Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylace Engine progress bar doesn't show up in Jupyter
2 participants