Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/parallel slice #177

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Feature/parallel slice #177

merged 2 commits into from
Feb 2, 2024

Conversation

BaxterEaves
Copy link
Contributor

No description provided.

@BaxterEaves BaxterEaves requested a review from a team as a code owner February 2, 2024 18:51
Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm glad it was so straightforward.

@@ -26,6 +26,3 @@ serde_yaml = "0.9.4"
approx = "0.5.1"
tempfile = "3.4"
indoc = "2.0.3"

[profile.release]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for the removal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

takes forever to compile

Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We'll have to remember to bump the lace_utils version before publishing, of course

@BaxterEaves BaxterEaves merged commit 67148b3 into master Feb 2, 2024
24 checks passed
@schmidmt schmidmt deleted the feature/parallel-slice branch May 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants