Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/flat columns in pylace ctor #179

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

BaxterEaves
Copy link
Contributor

Note that I made the tqdm update handler "private" so ruff wouldn't complain about public methods not having doc strings

@BaxterEaves BaxterEaves requested a review from schmidmt February 5, 2024 14:50
@BaxterEaves BaxterEaves requested a review from a team as a code owner February 5, 2024 14:50
Copy link
Contributor

@Swandog Swandog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this needs further documentation/explanation, because it's not obvious to me what this flag is doing; but I wouldn't hold up the PR for that.

LGTM!

Copy link
Contributor

@schmidmt schmidmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing up the tqdm stuff.

@BaxterEaves BaxterEaves merged commit 06fbf54 into master Feb 5, 2024
3 of 4 checks passed
@BaxterEaves BaxterEaves deleted the feature/flat-columns-in-pylace-ctor branch February 5, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants