Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Improved errors from type conversions. #180

Merged
merged 1 commit into from
Feb 6, 2024
Merged

feat(python): Improved errors from type conversions. #180

merged 1 commit into from
Feb 6, 2024

Conversation

schmidmt
Copy link
Contributor

@schmidmt schmidmt commented Feb 6, 2024

Use error returns instead of unwraps to help Python users detect errors.

@schmidmt schmidmt self-assigned this Feb 6, 2024
@schmidmt schmidmt requested a review from a team as a code owner February 6, 2024 16:05
@schmidmt schmidmt added enhancement New feature or request Python Pertains to the Python API labels Feb 6, 2024
BaxterEaves
BaxterEaves approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@BaxterEaves BaxterEaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@schmidmt schmidmt merged commit d66cb65 into master Feb 6, 2024
11 checks passed
@schmidmt schmidmt deleted the feat/improve-python-convertion-errors branch May 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaxterEaves BaxterEaves BaxterEaves approved these changes

Assignees

@schmidmt schmidmt

Labels
enhancement New feature or request Python Pertains to the Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmidmt @BaxterEaves