Handle undefined orientation #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17Amir17
approved these changes
Nov 10, 2024
| window.screen.orientation | ||
| window.screen.orientation ?? { type: "portrait-primary" } |
There was a problem hiding this comment.
nit: maybe we should do window.screen?.orientation for the 3% of devices that don't support it
rrrliu
reviewed
Nov 10, 2024
rrrliu
approved these changes
Nov 10, 2024
| window.screen.orientation | ||
| window.screen.orientation ?? { type: "portrait-primary" } |
rrrliu
added a commit
that referenced
this pull request
Nov 10, 2024
In browsers where `window.screen.orientation` is undefined, provide a default. --------- Co-authored-by: Richard Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In browsers where
window.screen.orientationis undefined, provide a default.