POD Email PCD #2193
Merged
POD Email PCD #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robknight
force-pushed
the
robknight/0xp-1081-issue-email-pcd-as-pod
branch
from
dcd8f49 to
5c4c4a4
Compare
robknight
force-pushed
the
robknight/0xp-1081-issue-email-pcd-as-pod
branch
from
b993671 to
3ba651e
Compare
rrrliu
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a POD version of the Email PCD.
The new PCD wraps a POD in a similar manner to PODTicketPCD. The POD contains the user's email address and Semaphore v4 public key (note: Semaphore v3 identity is not included - is there a use-case for including it?)
passport-serverhas been updated to issue a POD Email PCD alongside every legacy Email PCD.passport-clienthas been updated to hide the visual display of POD Email PCDs in the same way that it does with Email PCDs.The next step after this PR would be to switch over to using POD Email PCDs as part of feed credentials, in place of the legacy Email PCD.