-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-up fixes #1
Open
isaacfinnegan
wants to merge
84
commits into
proofpoint:master
Choose a base branch
from
isaacfinnegan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
re-up fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery for service records with specific attribute/values. this could not be done in the sql, so the query results are filtered by the query params using noms::jcel
… new system record
…rvice record is deleted
… being updated. stub function to test for value change. better empty string / null handling to come
… changes being logged to inv_audit. also fix for warning on undef $key
… Audit methods. should NOT be using generic as it would allow PUT/DELETE. config files will need updating.
…e error log Change-Id: Ie21602923b1e9535d21ceeb6669fa96c7165c98b
Change-Id: Ic5601535c5458bf483f8a1b29b369b4b6717b7eb
Change-Id: I4e06320879ac738f5fd33c13668204f55420e969
Change-Id: I95e7bcf3fb8872c1d7e2da5f845d848ece3276d5
Change-Id: I412ee729803ca2d68553fb8320e58069d956e04d
Change-Id: Id3a7efb45e1c453fe3cb74ff21418f2b31257130
… to trigger new build editing commit message to try to trigger build (and again) (and again) Change-Id: I760aa6dd9bc341804dcfba9a88b8d15554fcc034
Change-Id: I27d2a4cccf0320fdf5c9540dfeba865503da7919
Renaming it to avoid any risk of a package upgrade clobbering the most recent puppet-managed one Change-Id: I1c0b5f5649af0551dd2e5b90171a9b2b937881da
…24 package Change-Id: I0ff6a5157aa2a3bebfd2ecb329d5aa15bce8efa8
Change-Id: Ifd1219e38b5cc2ef5e3729cf26ca6a438dff93ff
clean up error log spam
Publish logging and testing changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly minor fixes. Refactored out ipaddress field into config item, among other things. consult cmdb_api.conf