Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: convert UUID_BINARY in pk on update #1981

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mringler
Copy link
Contributor

Fixes issue in comment.

I have also changed the UuidConverter, so that it handles null values. The initial idea was to be strict with the type, but it is not robust and lead to ugly code, where the null check has to be performed manually every time.

Includes test fix from #1980, otherwise tests would fail.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f36eea) 89.27% compared to head (6b29c6d) 89.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1981   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
- Complexity     8049     8052    +3     
=========================================
  Files           232      232           
  Lines         24519    24527    +8     
=========================================
+ Hits          21889    21897    +8     
  Misses         2630     2630           
Flag Coverage Δ
5-max 89.27% <93.75%> (+<0.01%) ⬆️
7.4 89.27% <93.75%> (+<0.01%) ⬆️
agnostic 67.47% <68.75%> (+<0.01%) ⬆️
mysql 69.81% <87.50%> (+<0.01%) ⬆️
pgsql 69.92% <87.50%> (+0.08%) ⬆️
sqlite 67.88% <87.50%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Propel/Runtime/Util/UuidConverter.php 80.64% <100.00%> (+2.86%) ⬆️
src/Propel/Generator/Builder/Om/ObjectBuilder.php 93.86% <90.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mringler mringler force-pushed the bugfix/convert_uuid_in_pk_on_update branch from f5ccdb9 to 6b29c6d Compare September 30, 2023 07:00
@mringler mringler mentioned this pull request Sep 30, 2023
@mringler mringler changed the title convert UUID_BINARY in pk on update Bugfix: convert UUID_BINARY in pk on update Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUID type support
2 participants