use specific fns instead of massive paths obj

[goastler]

No description provided.

[pr-explainer-bot]

Hey there! 👋 I see you need help summarizing the previous results for a Pull Request review markdown doc. Let's get started!

Changes 📝

1. In the projectInfo.ts file, the 'fs' module was imported in the 'projectInfo.ts' file, and a new function called 'getContractNames' was added. This function uses 'fs.readdirSync' to read the protocol contracts directory and filter the names of the directories.
2. In the setVersion.ts file, the import statement for 'getPaths' from '@prosopo/config' was removed and replaced with 'getRootDir' from the same module.

Suggestions 🤔

1. In the projectInfo.ts file, instead of manually defining each path in the 'Paths' type and returning an object with all the paths, it could be refactored to dynamically generate the paths based on a predefined structure. This would make the code more maintainable and scalable.
2. In the setVersion.ts file, the 'find' function could be refactored to use the 'fs' module's 'readdirSync' method with a filter function to find the files instead of walking through all the files recursively. This would simplify the code and improve performance.

Bugs 🐛

1. In the paths.test.ts file, the test case 'paths exist' checks if all the paths defined in the 'Paths' object exist by using 'fs.existsSync'. However, it doesn't handle the case where a path is a file instead of a directory. This could potentially lead to false positives or false negatives in the test results.
2. In the setVersion.ts file, the 'ignorePaths' array is hardcoded with some paths to ignore. This could be a potential source of bugs if the directory structure changes or if there are platform-specific paths that need to be ignored. It would be better to provide a configuration option to specify the paths to ignore.

Improvements ✨

1. In the dev/scripts/src/cli/index.ts file, the code block starting from line 106 can be refactored for better readability. Instead of using a loop, consider using the Array.map() function to iterate over the contracts array and perform the exec() function on each contract. Here's a possible refactored code snippet:

const contracts = getContractNames()

await Promise.all(contracts.map(async (contract) => {
  const inDir = `${getProtocolDistDir()}/${contract}`
  await exec(`node dist/cli/index.js import_contract --in=${inDir} --out=${getContractsDir()}/${contract}/src`)
}))

Rating ⭐️

Overall, I would rate the code a 7.5 out of 10. The code is generally readable, but there are some areas that could be improved with comments and better variable naming. Performance-wise, there are potential optimizations in the loop on line 154. In terms of security, it's difficult to assess without more context on the code's purpose and potential vulnerabilities.

That's it! Feel free to copy and paste this into your Pull Request review markdown doc. If you need any more assistance, just let me know! 😉