Tech debt #1391

HughParry · 2024-09-23T09:44:15Z

No description provided.

forgetso

2 small comments but overall LGTM

packages/account/src/config/getMnemonic.ts

packages/account/tsconfig.json

packages/account/src/config/getPair.ts

packages/account/src/extension/ExtensionWeb2.ts

packages/account/tsconfig.json

packages/common/src/tests/array.test.ts

packages/common/src/tests/logger.test.ts

HughParry added 11 commits September 20, 2024 10:28

Dropping contracts package

f3abe84

Web extensions slight refactor

6a48286

Array join unit testing

ef6335a

Removing unused custom.ts i18 module declaration

8b6d5cd

Dropping unused capitaliseFirstLetter function

d4c69b4

Unit tests for logger

a4a5fd0

Removing unused TranslationFileSchema

acf4762

Revert

aec8e8c

Removing unused deps for common

04b58db

merge

a2b82e0

deps fixes

b285e48

HughParry requested review from forgetso and goastler as code owners September 23, 2024 09:44

HughParry changed the base branch from main to staging September 23, 2024 09:44

forgetso requested changes Sep 23, 2024

View reviewed changes

packages/account/src/config/getMnemonic.ts Outdated Show resolved Hide resolved

packages/account/tsconfig.json Outdated Show resolved Hide resolved

HughParry added 2 commits September 23, 2024 10:56

Renaming mnemonic file name

8a51b98

tsconfig broken in account package

e5a205d

goastler requested changes Sep 23, 2024

View reviewed changes

Fixing types

cf73136

goastler approved these changes Sep 23, 2024

View reviewed changes

Merge branch 'staging' into tech-debt

76f33e2

HughParry marked this pull request as draft October 14, 2024 18:33

Base automatically changed from staging to main October 18, 2024 18:23

HughParry closed this Dec 19, 2024

Provide feedback