Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove npm release check for testing provider mock #1450

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove npm release check for testing provider mock #1450

wants to merge 1 commit into from

Conversation

goastler
Copy link
Member

No description provided.

@goastler goastler self-assigned this Oct 14, 2024
@goastler
Copy link
Member Author

could do with @forgetso taking a look at this. Not sure if there was a reason why the provider mock was waiting on npm releases

HughParry
HughParry reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@HughParry HughParry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts bugfix here #1450

The dockerfile is small and only grabs the demo packages it needs so is only pulling from npm not from workspace

@HughParry HughParry marked this pull request as draft October 15, 2024 09:33
Base automatically changed from staging to main October 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HughParry HughParry HughParry left review comments

@forgetso forgetso Awaiting requested review from forgetso forgetso is a code owner

Assignees

@goastler goastler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goastler @HughParry