Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change json constructor #1

Merged
merged 2 commits into from
Jul 11, 2024
Merged

change json constructor #1

merged 2 commits into from
Jul 11, 2024

Conversation

alexsilaghi
Copy link
Contributor

simple change in json constructor for FE

matthewhorridge
matthewhorridge reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@matthewhorridge matthewhorridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need a bit more background for these changes. We have a deserialization test that is now failing caused by moving the JsonCreator annotation from one factory method (with AnnotationValueProxy) to the other factory method (with a plain AnnotationValue)

@matthewhorridge matthewhorridge self-assigned this Jun 27, 2024
@matthewhorridge matthewhorridge merged commit 348028b into main Jul 11, 2024
1 check passed
@matthewhorridge matthewhorridge deleted the WHO-setup branch July 11, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhorridge matthewhorridge matthewhorridge left review comments

Assignees

@matthewhorridge matthewhorridge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsilaghi @matthewhorridge