Use standard "@type" instead of "type"

protegeproject · Jul 3, 2024 · a494e2a · a494e2a
1 parent 79bba83
commit a494e2a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/main/java/edu/stanford/protege/webprotege/forms/field/ChoiceListSourceDescriptor.java b/src/main/java/edu/stanford/protege/webprotege/forms/field/ChoiceListSourceDescriptor.java
@@ -8,7 +8,7 @@
  * Stanford Center for Biomedical Informatics Research
  * 2020-01-11
  */
-@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "type")
+@JsonTypeInfo(use = JsonTypeInfo.Id.NAME)
 @JsonSubTypes({@JsonSubTypes.Type(value = FixedChoiceListSourceDescriptor.class, name = FixedChoiceListSourceDescriptor.TYPE), @JsonSubTypes.Type(value = DynamicChoiceListSourceDescriptor.class, name = DynamicChoiceListSourceDescriptor.TYPE)})
 public interface ChoiceListSourceDescriptor {
 

diff --git a/...va/edu/stanford/protege/webprotege/forms/field/DynamicChoiceListSourceDescriptorTest.java b/...va/edu/stanford/protege/webprotege/forms/field/DynamicChoiceListSourceDescriptorTest.java
@@ -23,14 +23,14 @@ class DynamicChoiceListSourceDescriptorTest {
     void shouldSerialize() throws IOException {
         var written = tester.write(DynamicChoiceListSourceDescriptor.get(CompositeRootCriteria.get(List.of(), MultiMatchType.ALL)));
         System.out.println(written.getJson());
-        assertThat(written).hasJsonPathStringValue("type", "Dynamic");
+        assertThat(written).hasJsonPathStringValue("['@type']", "Dynamic");
         assertThat(written).hasJsonPathValue("criteria");
     }
 
     @Test
     void shouldDeserialize() throws IOException {
         var json = """
-                {"type":"Dynamic","criteria":{"match":"CompositeCriteria","criteria":[],"matchType":"ALL"}}
+                {"@type":"Dynamic","criteria":{"match":"CompositeCriteria","criteria":[],"matchType":"ALL"}}
                 """;
         var read = tester.read(new StringReader(json));
         assertThat(read).isInstanceOf(DynamicChoiceListSourceDescriptor.class);

diff --git a/...java/edu/stanford/protege/webprotege/forms/field/FixedChoiceListSourceDescriptorTest.java b/...java/edu/stanford/protege/webprotege/forms/field/FixedChoiceListSourceDescriptorTest.java
@@ -24,14 +24,14 @@ class FixedChoiceListSourceDescriptorTest {
     void shouldSerialize() throws IOException {
         var written = tester.write(FixedChoiceListSourceDescriptor.get(ImmutableList.of()));
         System.out.println(written.getJson());
-        assertThat(written).hasJsonPathStringValue("type", "Dynamic");
+        assertThat(written).hasJsonPathStringValue("['@type']", "Fixed");
         assertThat(written).hasJsonPathValue("choices");
     }
 
     @Test
     void shouldDeserialize() throws IOException {
         var json = """
-                {"type":"Fixed","choices":[]}
+                {"@type":"Fixed","choices":[]}
                 """;
         var read = tester.read(new StringReader(json));
         assertThat(read).isInstanceOf(FixedChoiceListSourceDescriptor.class);