Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/guild #2167

Merged
merged 24 commits into from
Aug 11, 2021
Merged

feature/guild #2167

merged 24 commits into from
Aug 11, 2021

Conversation

hexyls
Copy link
Contributor

@hexyls hexyls commented Aug 10, 2021

Testing:

  • Airdrop on xdai tight integration works (I redeployed)
  • Guild lock/unlock works on Rinkeby (you will need rinkeby OMN to test)

If there are issues please dive in and try to resolve them, need to get this branch merged asap

Mi-Lan and others added 24 commits July 1, 2021 12:16
* started working on lock tokens modal and added rinkeby omen address

* added rough outline for the omen guild membership modal

* started working on lock omen token modal

* added front-end fixes for lock omen token modal with input and made contents DRY as can be with new display feature i found

* small css adjustments

* some css to make row gaps

* started working on guild service

* tidied up omen guild service so it works and added two more functions

* made all data display

* started adjusting contracts and integrating it into cpk encountered minor block

* fixed guild service issue

* got lock function working

* fixes for the guild service and calculation

* added disabled button logic

* done with style details excluded grid

* added your vote weight percentage change and added unlock function along with changes to ethers sc stuff

* cleaned up unused code and abi

* added correct date formatting along with one missing abi

* added omen icons and fixed couple things

* handled cpk bug because of no relay

* fixed incorrect unlock calculation for timestamp

* added transaction modal and started looking into fixing cpk

* fixing transaction state modal issue

* added tooltip

* started workig on allowance logic

* approve button implemented with logic

* working in progress

* cracked motherfucker

* tidied up code and added check to fetch appropriate amounts if on mainnet versus other cases

* fixed type issue with transaction steps along with fex minor front-end fixes

* added null state for unlock date

* correct modal shows after transaction and balances update correctly

* fixed all comments

* fix for vote weight showing difference on incorrect place

* fix Button animation removed

* style Added hover styling for modal info icon and cursor

* test: Test for formatLockDate function

* style: Fixed bucnh of styling issue from Kadens comments

* fix: Removed all instances of getting omenTokenAddress directly from SC but made them fetched from knownTokens

* refactor: Deleted getOmenGuildContract and moved that logic into the constructor as suggested by Kaden

* fix: Fixed unlock tokens so they transfer token to address on xDai,leave it on cpk on tight and regular transfer on mainnet/rinkeby

* test: Added daysUntil test

Co-authored-by: Thomas Pulber <[email protected]>
* add ModalAirdrop

* add airdrop service

* refactor airdrop service, deploy rinkeby airdrop, add useAidropService

* refetch balances after claim, add airdropAddress to network interface

* add xdai aidrop

* fix annoying error messages

* add check address error message

* support multiple independent airdrops

* handle proxy as recipient address

* only display modal with web3 connection and claimable balance

* update styles, handle displayAmount, update airdrop sets

* handle race condition, don't display proxy claims on direct xdai

* redeploy xdai airdrop

* redeploy airdrops

* handle undefined transaction arr

* fix: merge with feature/guild

Co-authored-by: Thomas Pulber <[email protected]>
Co-authored-by: Violet <[email protected]>
…en-exchange into feature/airdrop-guild-modal
* feature: add airdrop card to guild modal

* fix: style changes, testing airdrop

* style: Reduce margin from 32px to 24px for diver and button group

* fix: refetch claimable balance

* fix: reset check address claim amount

* fix: generalized onClose for guild modal

* fix: update rinkeby airdrop

Co-authored-by: Thomas Pulber <[email protected]>
* feature: add airdrop card to guild modal

* fix: style changes, testing airdrop

* style: Reduce margin from 32px to 24px for diver and button group

* fix: refetch claimable balance

* fix: reset check address claim amount

* fix: display omen account on tight integration

* fix: capitalize wallet balance

* fix: combine relay and eoa omn balances

Co-authored-by: Thomas Pulber <[email protected]>
Display omen account and wallet balance in guild modal
@pimato pimato requested a review from Frankaus August 11, 2021 09:25
@pimato
Copy link
Contributor

pimato commented Aug 11, 2021

  • Airdrop on xdai tight integration works (I redeployed)
  • Guild lock/unlock works on Rinkeby (you will need rinkeby OMN to test)

I have found two minor bugs which should be resolved in a separate PR:

Copy link
Contributor

@pimato pimato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Frankaus
Copy link
Contributor

Frankaus commented Aug 11, 2021

The app overall works well. From the feature/guild branch I can't see the TST/OMN tokens I could redeem yesterday on feature/2093 and it tells me Address has no available claim when I check for the my address set by Hexyls. TST/OMN properly show when I'm on feature/2093. Talking with Geronimo yesterday, he mentioned that could be normal for me since I never had OMN nor deposited DAI with that address

Copy link
Contributor

@Mi-Lan Mi-Lan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good! Nice job! Also one more thing not sure why I can't see claim transaction done through the xDai tight? Is it something blockscout related or? I did receive it though...
Screenshot 2021-08-11 at 13 03 23
https://blockscout.com/poa/xdai/tx/0x3c7c4bb691ca05a0626146161f2ac39e1bfcb6545cb4fe1bb8c47bc8b942a6a6

@pimato pimato merged commit b7a85f7 into master Aug 11, 2021
@pimato pimato deleted the feature/guild branch August 11, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants